Skip to content

[INLONG-6103][Manager] Support update and save cluster switch info#6200

Closed
vernedeng wants to merge 8 commits intoapache:masterfrom
vernedeng:INLONG-6103
Closed

[INLONG-6103][Manager] Support update and save cluster switch info#6200
vernedeng wants to merge 8 commits intoapache:masterfrom
vernedeng:INLONG-6103

Conversation

@vernedeng
Copy link
Contributor

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link
Contributor

@luchunliang luchunliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

private String description;
private String mqType;
private String mqResource;
private String backupMqResource;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not recommended to add special backup configurations.

You can put them in the ext_params field, or put them in the inlong_group_ext table.

@vernedeng
Copy link
Contributor Author

cluster switch info will be saved in inlong_group_ext and inlong_stream_ext, no need to add columns.

@vernedeng vernedeng closed this Oct 26, 2022
@vernedeng vernedeng deleted the INLONG-6103 branch May 26, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Manager] Support update and save cluster switch info

4 participants