Skip to content

[INLONG-6451][Manager] Optimize the resource process of Kafka MQ#6455

Merged
dockerzhang merged 5 commits intoapache:masterfrom
haifxu:improve-6451
Nov 8, 2022
Merged

[INLONG-6451][Manager] Optimize the resource process of Kafka MQ#6455
dockerzhang merged 5 commits intoapache:masterfrom
haifxu:improve-6451

Conversation

@haifxu
Copy link
Copy Markdown
Member

@haifxu haifxu commented Nov 8, 2022 •
edited
Loading

Prepare a Pull Request

Motivation

Using Kafka as MQ.

Modifications

  1. Remove the operation that creates a consumer for the Kafka topic, Kafka MQ does not need to create consumers in advance.
  2. Rewrite getSourcesMap for the Kafka source operator.

Verifying this change

  • This change is a trivial rework/code cleanup without test coverage.

@haifxu haifxu changed the title [INLONG-6451][Manager] Rewrite getSourcesMap for the Kafka source operator [INLONG-6451][Manager] Optimize the resource process of Kafka MQ Nov 8, 2022
@haifxu haifxu requested a review from healchow November 8, 2022 08:27
healchow
healchow approved these changes Nov 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@healchow healchow marked this pull request as draft November 8, 2022 09:34
@healchow healchow marked this pull request as ready for review November 8, 2022 10:17
@dockerzhang dockerzhang merged commit 577d8ab into apache:master Nov 8, 2022
dockerzhang pushed a commit that referenced this pull request Nov 8, 2022
@haifxu @dockerzhang
[INLONG-6451][Manager] Optimize the resource process of Kafka MQ (#6455)
7644e71
vernedeng pushed a commit to vernedeng/incubator-inlong that referenced this pull request Nov 9, 2022
@haifxu @vernedeng
[INLONG-6451][Manager] Optimize the resource process of Kafka MQ (apa…
9674ae1 
…che#6455)
@haifxu haifxu mentioned this pull request Nov 22, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dockerzhang dockerzhang dockerzhang approved these changes

@healchow healchow healchow approved these changes

Assignees

No one assigned

Labels

1.20.x/bugfix component/manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Rewrite getSourcesMap for Kafka source operator

3 participants

@haifxu @dockerzhang @healchow