[INLONG-6462][Manager] Support CLS datanode#6473
Closed
vernedeng wants to merge 2 commits intoapache:masterfrom
Closed
[INLONG-6462][Manager] Support CLS datanode#6473vernedeng wants to merge 2 commits intoapache:masterfrom
vernedeng wants to merge 2 commits intoapache:masterfrom
Conversation
ciscozhou
approved these changes
Nov 10, 2022
fuweng11
reviewed
Nov 15, 2022
| */ | ||
| public static ClsDataNodeDTO getFromRequest(ClsDataNodeRequest request) { | ||
| return ClsDataNodeDTO.builder() | ||
| .baseRetryBackoffMs(request.getBaseRetryBackoffMs()) |
Contributor
There was a problem hiding this comment.
Recommended use CommonBeanUtils.copyProperties(request, ClsDataNodeDTO::new, true);
yunqingmoswu
approved these changes
Dec 26, 2022
Contributor
|
Please handle the code conflict. |
Contributor
|
there is no CLS user for InLong, all ClS PR and issues will close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
(Change the title refer to the following example)
(The following XYZ should be replaced by the actual GitHub Issue number)
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve?
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation