[INLONG-6839][Sort] Clean up remain event when the related stream is offline#6840
Merged
dockerzhang merged 2 commits intoapache:masterfrom Dec 12, 2022
Merged
[INLONG-6839][Sort] Clean up remain event when the related stream is offline#6840dockerzhang merged 2 commits intoapache:masterfrom
dockerzhang merged 2 commits intoapache:masterfrom
Conversation
vernedeng
changed the title
vernedeng
changed the title
gosonzhang
approved these changes
Dec 12, 2022
dockerzhang
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
The remain event will stay in memory forever since there is no any idConfig related to this event when stream offline.
This will cause memory leak and poor performance.
Modifications
Just ack and discards those events which does not relate any idConfigs.
Verifying this change
Documentation