Skip to content

[INLONG-6899][Sort] StarRocks supports table level metric#6903

Merged
gong merged 2 commits intoapache:masterfrom
liaorui:feature-starrocks
Dec 21, 2022
Merged

[INLONG-6899][Sort] StarRocks supports table level metric#6903
gong merged 2 commits intoapache:masterfrom
liaorui:feature-starrocks

Conversation

@liaorui
Copy link
Contributor

@liaorui liaorui commented Dec 15, 2022

Prepare a Pull Request

Motivation

StarRocks supports table level metrics.

image

Modifications

Describe the modifications you've done.

  1. SinkSubMetricData and SinkTableMetricData provide method to collect the metrics, inspired by SourceSubMetricData and SourceTableMetricData.
  2. Replaced SinkMetricData with SinkTableMetricData in StarRocksSinkManager and StarRocksDynamicSinkFunction.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@dockerzhang dockerzhang changed the title [INLONG-6899][Sort]StarRocks supports table level metric [INLONG-6899][Sort] StarRocks supports table level metric Dec 16, 2022
@gong
Copy link
Contributor

gong commented Dec 16, 2022

starrack lost node level dirty data metric restore

@gong gong merged commit d012427 into apache:master Dec 21, 2022
@liaorui liaorui deleted the feature-starrocks branch December 23, 2022 06:11
featzhang pushed a commit to featzhang/inlong that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Sort] StarRocks-CDC supports table level metrics

5 participants