Skip to content

[INLONG-6907][SortStandalone] Support to close StatsRecorder of pulsar client#6911

Merged
dockerzhang merged 5 commits intoapache:masterfrom
luchunliang:INLONG-6907
Dec 16, 2022
Merged

[INLONG-6907][SortStandalone] Support to close StatsRecorder of pulsar client#6911
dockerzhang merged 5 commits intoapache:masterfrom
luchunliang:INLONG-6907

Conversation

@luchunliang
Copy link
Contributor

@luchunliang luchunliang commented Dec 16, 2022

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@luchunliang luchunliang changed the title [INLONG-6907][SortStandalone] Support to close StatsRecorder of pulsar [INLONG-6907][SortStandalone] Support to close StatsRecorder of pulsar client Dec 16, 2022
@dockerzhang
Copy link
Contributor

@luchunliang please rebase from master and build locally before creating a PR, and it will fix the format error automatically.

Copy link
Contributor

@vernedeng vernedeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dockerzhang dockerzhang merged commit c13113c into apache:master Dec 16, 2022
featzhang pushed a commit to featzhang/inlong that referenced this pull request Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][SortStandalone] Support to close StatsRecorder of pulsar client

4 participants