[INLONG-6780][Sort] Supports dirty data side-output for JDBC connector and related sinks#6921
Closed
Yizhou-Yang wants to merge 20 commits intoapache:masterfrom
Closed
[INLONG-6780][Sort] Supports dirty data side-output for JDBC connector and related sinks#6921Yizhou-Yang wants to merge 20 commits intoapache:masterfrom
Yizhou-Yang wants to merge 20 commits intoapache:masterfrom
Conversation
…-yyz into inlong-oracle
EMsnap
reviewed
Dec 16, 2022
| private Long dataSize = 0L; | ||
| private Long rowSize = 0L; | ||
|
|
||
| private final Set<In> batchMap = new HashSet<>(); |
Contributor
|
@Yizhou-Yang please create a new issue to link this PR, thanks. |
| } catch (SQLException e) { | ||
| LOG.error("JDBC executeBatch error, retry times = {}", i, e); | ||
| if (i >= executionOptions.getMaxRetries()) { | ||
| clearBatch(e); |
Contributor
There was a problem hiding this comment.
If you choose to throw an exception, there is no need to report dirty data
| LOG.error( | ||
| "JDBC connection is not valid, and reestablish connection failed.", | ||
| exception); | ||
| clearBatch(exception); |
Contributor
There was a problem hiding this comment.
If you choose to throw an exception, there is no need to report dirty data
Contributor
Author
|
close for now, I don't think this is necessary to be merged rn,this pr does not change functionality. will reopen if it is required in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add jdbc flush exception via batchmap (which is actually a batchset for jdbc)
fix #6780