[INLONG-7073][Sort] Support table level metrics for Apache Iceberg connector#7118
Merged
gong merged 2 commits intoapache:masterfrom Jan 4, 2023
Merged
[INLONG-7073][Sort] Support table level metrics for Apache Iceberg connector#7118gong merged 2 commits intoapache:masterfrom
gong merged 2 commits intoapache:masterfrom
Conversation
healchow
reviewed
Jan 2, 2023
.../src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/DynamicSchemaHandleOperator.java
Outdated
Show resolved
Hide resolved
thesumery
force-pushed
the
7073
branch
2 times, most recently
from
fee0a24 to
0182473
Compare
healchow
approved these changes
Jan 3, 2023
gong
reviewed
Jan 3, 2023
...onnectors/base/src/main/java/org/apache/inlong/sort/base/metric/sub/SinkTableMetricData.java
Outdated
Show resolved
Hide resolved
Contributor
|
lost table level metric restore |
yunqingmoswu
approved these changes
Jan 3, 2023
EMsnap
approved these changes
Jan 3, 2023
Contributor
Author
table level metric are in IcebergMultipleStreamWriter line 191，restore table metric at runtime |
Contributor
@thesumery maybe you need call SinkTableMetricData#registerSubMetricsGroup for table level metric restore |
Contributor
Author
It‘s different from other multiple sink connector.It's a 'IcebergMultipleStreamWriter' include many 'IcebergSingleStreamWriter'，so SinkTableMetricData#registerSubMetricsGroup it not suitable for this. |
gong
approved these changes
Jan 4, 2023
dockerzhang
pushed a commit
that referenced
this pull request
Jan 4, 2023
liaorui
pushed a commit
to liaorui/inlong
that referenced
this pull request
Feb 20, 2023
…nnector (apache#7118) (cherry picked from commit e305ae8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[INLONG-7073][Sort] Support table level metrics for Apache Iceberg connector
Prepare a Pull Request
Motivation
Support table level metrics for Apache Iceberg connector