[INLONG-5776][Manager] Add tenant param to InlongGroup that uses Pulsar#7171
[INLONG-5776][Manager] Add tenant param to InlongGroup that uses Pulsar#7171dockerzhang merged 3 commits intoapache:masterfrom
Conversation
|
@chestnut-c please help to review it |
|
This is a reasonable change, but it may lead to a configure failure for current SortStandalone and DataProxy.
|
.../org/apache/inlong/manager/service/listener/consume/apply/ApproveConsumeProcessListener.java
Outdated
Show resolved
Hide resolved
...r-service/src/main/java/org/apache/inlong/manager/service/consume/ConsumePulsarOperator.java
Outdated
Show resolved
Hide resolved
Thanks for your review🎉 As I considered compatibility with DataProxy and SortStandalone, I did not add the default value for the tenant in the InlongPulsarRequest, see the code: That is to say, if you do not set the tenant value when creating or modifying InlongGroup, DataProxy and SortStandalone will read the tenant from the PulsarCluster when they obtain the tenant, because there is no tenant in InlongGroup. This way should be compatible with historical data. And finally, if you want to upgrade all historical data, you need to modify the request methods of DataProxy / SortStandalone and copy the tenant configuration from PulsarClusters to the related InlongGroups. |
Prepare a Pull Request
Motivation
Add tenant param to InlongGroup that uses Pulsar.
Currently, the tenant parameter is stored in the Pulsar cluster information, which is not reasonable.
Because a Pulsar cluster supports many tenants, just like its namespaces and topics, it is a one-to-many relationship with the cluster, not a one-to-one relationship.
Modifications
tenantparam forInlongPulsarInfo.InlongPulsarInfo, and then get it from thePulsarCluster, finally, use the default tenantpublic.Verifying this change
Documentation