[INLONG-7299][Sort] Optimize the options check for the Kafka connector#7471
Merged
dockerzhang merged 1 commit intoapache:masterfrom Mar 1, 2023
Merged
[INLONG-7299][Sort] Optimize the options check for the Kafka connector#7471dockerzhang merged 1 commit intoapache:masterfrom
dockerzhang merged 1 commit intoapache:masterfrom
Conversation
dockerzhang
requested review from
gong,
thexiay and
yunqingmoswu
and removed request for
gong and
yunqingmoswu
Member
|
LGTM |
yunqingmoswu
approved these changes
Mar 1, 2023
Member
|
+1 |
gosonzhang
approved these changes
Mar 1, 2023
EMsnap
approved these changes
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
(Change the title refer to the following example)
(The following XYZ should be replaced by the actual GitHub Issue number)
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve?
Modifications
ExtractNodeUtils.parsingFormat(), so it does not need to check again for Kafka ExtractNode.valueFormatPrefixcheck for `inlong-msg.' prefix options.