Skip to content

[INLONG-7485][Sort] Kafka extract node decide connector option by format #7486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dockerzhang merged 2 commits into from
Mar 2, 2023
Merged

[INLONG-7485][Sort] Kafka extract node decide connector option by format #7486

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
200ff20
[INLONG-7485][Sort] Kafka extract node decide connector option by format
gong Mar 1, 2023
67db1a3
[INLONG-7485][Sort] Kafka extract node decide connector option by format
gong Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions ...t-common/src/main/java/org/apache/inlong/sort/protocol/node/extract/KafkaExtractNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@
import org.apache.inlong.sort.protocol.constant.KafkaConstant;
import org.apache.inlong.sort.protocol.enums.KafkaScanStartupMode;
import org.apache.inlong.sort.protocol.node.ExtractNode;
import org.apache.inlong.sort.protocol.node.format.AvroFormat;
import org.apache.inlong.sort.protocol.node.format.CsvFormat;
import org.apache.inlong.sort.protocol.node.format.Format;
import org.apache.inlong.sort.protocol.node.format.JsonFormat;
import org.apache.inlong.sort.protocol.transformation.WatermarkField;

import javax.annotation.Nonnull;
Expand Down Expand Up @@ -147,12 +150,12 @@ public Map<String, String> tableOptions() {
options.put(KafkaConstant.TOPIC, topic);
options.put(KafkaConstant.PROPERTIES_BOOTSTRAP_SERVERS, bootstrapServers);
options.put(KafkaConstant.SCAN_STARTUP_MODE, kafkaScanStartupMode.getValue());
if (StringUtils.isEmpty(this.primaryKey)) {
options.put(KafkaConstant.CONNECTOR, KafkaConstant.KAFKA);
options.putAll(format.generateOptions(false));
} else {
if (isUpsertKafkaConnector(format, !StringUtils.isEmpty(this.primaryKey))) {
options.put(KafkaConstant.CONNECTOR, KafkaConstant.UPSERT_KAFKA);
options.putAll(format.generateOptions(true));
} else {
options.put(KafkaConstant.CONNECTOR, KafkaConstant.KAFKA);
options.putAll(format.generateOptions(false));
}
if (StringUtils.isNotEmpty(scanSpecificOffsets)) {
options.put(KafkaConstant.SCAN_STARTUP_SPECIFIC_OFFSETS, scanSpecificOffsets);
Expand All @@ -166,6 +169,21 @@ public Map<String, String> tableOptions() {
return options;
}

/**
* true is upsert kafka connector
* false is kafka connector
* @return Boolean variable that decides connector option
*/
private boolean isUpsertKafkaConnector(Format format, boolean hasPrimaryKey) {
if (format instanceof JsonFormat && hasPrimaryKey) {
return true;
} else if (format instanceof CsvFormat && hasPrimaryKey) {
return true;
} else {
return format instanceof AvroFormat && hasPrimaryKey;
}
}

@Override
public String genTableName() {
return String.format("table_%s", super.getId());
Expand Down