[INLONG-7546][Sort] Fix dirty data not archived for iceberg connector#7547
Merged
dockerzhang merged 1 commit intoapache:masterfrom Mar 8, 2023
lordcheng10:fix_dirtysink_not_open
Merged
[INLONG-7546][Sort] Fix dirty data not archived for iceberg connector#7547dockerzhang merged 1 commit intoapache:masterfrom lordcheng10:fix_dirtysink_not_open
dockerzhang merged 1 commit intoapache:masterfrom
lordcheng10:fix_dirtysink_not_open
Conversation
healchow
approved these changes
Mar 8, 2023
dockerzhang
approved these changes
Mar 8, 2023
yunqingmoswu
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
The S3DirtySink#open method is not called in IcebergSingleStreamWriter and IcebergMultipleStreamWriter, resulting in dirty data that may never be flushed and archived:
inlong/inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/dirty/sink/s3/S3DirtySink.java
Lines 108 to 113 in 12ee6c4
Modifications
In the open method of IcebergSingleStreamWriter and IcebergMultipleStreamWriter, call the DirtySink#open method