[INLONG-7589][Sort] Support multi node relation with same output but different input nodes#7590
Merged
dockerzhang merged 4 commits intoapache:masterfrom Mar 15, 2023
Merged
[INLONG-7589][Sort] Support multi node relation with same output but different input nodes#7590dockerzhang merged 4 commits intoapache:masterfrom
dockerzhang merged 4 commits intoapache:masterfrom
Conversation
…me output but different input nodes
gong
reviewed
Mar 14, 2023
inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/parser/AllMigrateTest.java
Show resolved
Hide resolved
e-mhui
approved these changes
Mar 14, 2023
healchow
approved these changes
Mar 15, 2023
dockerzhang
approved these changes
Mar 15, 2023
gong
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Now it's not capable for sort to generate multi insert sqls for one output with multiple inputs which is not acceptable for user cases.
For instance, user may want to get data from multiple data sources, they can only use union operation for now. But union operation in flink is too heavy.
We need to support generate sqls from one stream such that:
Insert into sink select * from sourceA;
Insert into sink select * from sourceB;
Modifications
Change the
parseNodetoParseSingleNodebecause the recuisive method will be multi branches which is not suitable for reading. And move the input nodes parsing outside ofparseNodemethod to make it easy for readingVerifying this change
Run
AllmigrateTestMultiRelations