[INLONG-8125][Sort] Optimizing the speed of transitioning from snapshot to binlog#8131
Merged
dockerzhang merged 9 commits intoapache:masterfrom Jun 6, 2023
Merged
[INLONG-8125][Sort] Optimizing the speed of transitioning from snapshot to binlog#8131dockerzhang merged 9 commits intoapache:masterfrom
dockerzhang merged 9 commits intoapache:masterfrom
Conversation
yunqingmoswu
approved these changes
Jun 5, 2023
EMsnap
reviewed
Jun 5, 2023
EMsnap
approved these changes
Jun 5, 2023
dockerzhang
approved these changes
Jun 5, 2023
gong
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
[INLONG-8125][Sort] Optimizing the speed of transitioning from snapshot to binlog
Motivation
When transitioning from the snapshot phase to the binlog phase, the
shouldEmit()method is called. Its function is to traverse all splits for each Binlog data and check whether the record is located after the end of the snapshot phase. However, the time complexity of this method is O(n). Since finishedSplitsInfo is locally ordered, we can use binary search to find the split where the current binlog is located, reducing the time complexity fromO(n)toO(logn).Modifications
MySqlSourceReaderreceives all theFinishedSnapshotSplitInfos, it sorts theFinishedSnapshotSplitInfosbased on the chunkId.