[INLONG-8154][Manager] Use the factory pattern to optimize the way of creating ExtractNodes#8155
Closed
chestnut-c wants to merge 12 commits intoapache:masterfrom
Closed
[INLONG-8154][Manager] Use the factory pattern to optimize the way of creating ExtractNodes#8155chestnut-c wants to merge 12 commits intoapache:masterfrom
chestnut-c wants to merge 12 commits intoapache:masterfrom
Conversation
…te ExtractNodeFactories to make it a single responsibility, easy to expand and maintain.
chestnut-c
changed the title
healchow
requested changes
Jun 4, 2023
...manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/node/AbstractNodeFactory.java
Show resolved
Hide resolved
...anager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/node/NodeProducer.java
Show resolved
Hide resolved
fuweng11
reviewed
Jun 5, 2023
...nager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/node/extract/PulsarFactory.java
Show resolved
Hide resolved
modify the name.
fuweng11
reviewed
Jun 5, 2023
...er/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/FieldFormatUtils.java
Outdated
Show resolved
Hide resolved
modify the name.
fuweng11
approved these changes
Jun 5, 2023
healchow
reviewed
Jun 5, 2023
...nager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/node/extract/KafkaProvider.java
Outdated
Show resolved
Hide resolved
healchow
changed the title
modify the javadoc.
…up id is not empty (apache#8153)
…te ExtractNodeFactories to make it a single responsibility, easy to expand and maintain.
# Conflicts: # inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java
Contributor
Author
|
Resubmit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[INLONG-8154][Manager] Optimize the way of creating ExtractNodes.
Motivation
Optimize the way of creating ExtractNodes, create ExtractNodeFactories to make it a single responsibility, easy to expand and maintain.