[INLONG-8251][Agent] Add global memory limit for file collect#8253
Merged
dockerzhang merged 11 commits intoapache:masterfrom Jun 16, 2023
Merged
[INLONG-8251][Agent] Add global memory limit for file collect#8253dockerzhang merged 11 commits intoapache:masterfrom
dockerzhang merged 11 commits intoapache:masterfrom
Conversation
add global memory limit for file collect, for three module: reader, channel and writer. the way to limit is semaphore.
EMsnap
reviewed
Jun 15, 2023
inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/task/MemoryManager.java
Show resolved
Hide resolved
EMsnap
reviewed
Jun 15, 2023
inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/task/MemoryManager.java
Show resolved
Hide resolved
add ut for memory manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
add global memory limit for file collect
Motivation
in some cases the jvm heap limits to 256m, but we need to collect more than 1001g files at the same time, that causes oom. maybe the file type would frequently change, but we dont want to change the configure all the time. so i just add the global memory limit no longer by the message count but by the total data len*
Modifications
add global memeory limit for file collect, for three module: reader, channel and writer. the way to limit is semaphore
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation