[INLONG-8290][Manager] Add tenant info into each query by SQL interceptor#8304
Merged
healchow merged 7 commits intoapache:masterfrom Jun 26, 2023
Merged
[INLONG-8290][Manager] Add tenant info into each query by SQL interceptor#8304healchow merged 7 commits intoapache:masterfrom
healchow merged 7 commits intoapache:masterfrom
Conversation
healchow
requested changes
Jun 21, 2023
...er-common/src/main/java/org/apache/inlong/manager/common/tenant/MultitenancyQueryFilter.java
Outdated
Show resolved
Hide resolved
...ger-dao/src/main/java/org/apache/inlong/manager/dao/interceptor/MultitenancyInterceptor.java
Outdated
Show resolved
Hide resolved
...ger-dao/src/main/java/org/apache/inlong/manager/dao/interceptor/MultitenancyInterceptor.java
Outdated
Show resolved
Hide resolved
Member
|
@vernedeng Please add more design detail in the PR comment, thanks. |
Contributor
Author
The main idea to achieve multiple tenant is to check the request permission in the web fitler #8201 , and add the target tenant at SQL preparation stage by annotating those queries. The developers just focus on the business logic, all current permission-related processes will be removed. |
fuweng11
reviewed
Jun 26, 2023
...ager-dao/src/main/java/org/apache/inlong/manager/dao/interceptor/MultitenantInterceptor.java
Outdated
Show resolved
Hide resolved
...ger-common/src/main/java/org/apache/inlong/manager/common/tenant/MultitenantQueryFilter.java
Outdated
Show resolved
Hide resolved
...ager-dao/src/main/java/org/apache/inlong/manager/dao/interceptor/MultitenantInterceptor.java
Outdated
Show resolved
Hide resolved
fuweng11
approved these changes
Jun 26, 2023
dockerzhang
approved these changes
Jun 26, 2023
healchow
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve?
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation