Skip to content

[INLONG-8953][Sort] Fix Iceberg source defaults the StartSnapshot to the latest#8954

Merged
dockerzhang merged 1 commit intoapache:masterfrom
vernedeng:INLONG-8953
Sep 21, 2023
Merged

[INLONG-8953][Sort] Fix Iceberg source defaults the StartSnapshot to the latest#8954
dockerzhang merged 1 commit intoapache:masterfrom
vernedeng:INLONG-8953

Conversation

@vernedeng
Copy link
Copy Markdown
Contributor

@vernedeng vernedeng commented Sep 20, 2023

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

Iceberg source force defaults the StartSnapshot to the latest and cannot be reset.

Modifications

Offer the option to allow the user to assign the start snapshot strategy from the earliest.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng self-assigned this Sep 20, 2023
@vernedeng vernedeng added this to the 1.9.0 milestone Sep 20, 2023
@vernedeng vernedeng changed the title [INLONG-8953][Sort] Iceberg source default the StartSnapshot to the latest [INLONG-8953][Sort] Fix Iceberg source default the StartSnapshot to the latest Sep 20, 2023
@vernedeng vernedeng changed the title [INLONG-8953][Sort] Fix Iceberg source default the StartSnapshot to the latest [INLONG-8953][Sort] Fix Iceberg source defaults the StartSnapshot to the latest Sep 20, 2023
EMsnap

This comment was marked as resolved.

@dockerzhang dockerzhang merged commit cc569c9 into apache:master Sep 21, 2023
@healchow healchow removed this from the 1.9.0 milestone Oct 8, 2023
liaosunny123 pushed a commit to liaosunny123/inlong that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Sort] Iceberg source default the StartSnapshot to the latest

4 participants