[INLONG-9766][Audit] Support user-defined SocketAddress loader getting AuditProxy#9767
Merged
dockerzhang merged 6 commits intoapache:masterfrom Mar 6, 2024
Merged
[INLONG-9766][Audit] Support user-defined SocketAddress loader getting AuditProxy#9767dockerzhang merged 6 commits intoapache:masterfrom
dockerzhang merged 6 commits intoapache:masterfrom
Conversation
luchunliang
added
the
service/ci
luchunliang
requested review from
EMsnap,
baomingyu,
dockerzhang,
gosonzhang,
justinwwhuang and
vernedeng
github-actions
bot
added
component/audit
and removed
service/ci
doleyzi
approved these changes
Mar 4, 2024
gosonzhang
previously approved these changes
Mar 5, 2024
aloyszhang
reviewed
Mar 5, 2024
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/util/Decoder.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Mar 5, 2024
Contributor
aloyszhang
left a comment
aloyszhang
left a comment
There was a problem hiding this comment.
Overall, LGTM. Just left a comment, PTAL
dockerzhang
reviewed
Mar 5, 2024
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/DnsIpPortListLoader.java
Outdated
Show resolved
Hide resolved
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/DnsIpPortListLoader.java
Outdated
Show resolved
Hide resolved
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/DnsIpPortListLoader.java
Outdated
Show resolved
Hide resolved
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/IpPortListLoader.java
Outdated
Show resolved
Hide resolved
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/util/IpPort.java
Outdated
Show resolved
Hide resolved
luchunliang
changed the title
dockerzhang
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
(Change the title refer to the following example)
(The following XYZ should be replaced by the actual GitHub Issue number)
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve?
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation