Skip to content

[INLONG-9893][Common] Optimized code InLongMsg#9894

Merged
dockerzhang merged 4 commits into
apache:masterfrom
beatCao:INLONG-9893
Mar 31, 2024
Merged

[INLONG-9893][Common] Optimized code InLongMsg#9894
dockerzhang merged 4 commits into
apache:masterfrom
beatCao:INLONG-9893

Conversation

@beatCao
Copy link
Copy Markdown
Contributor

@beatCao beatCao commented Mar 28, 2024

Title Name: [INLONG-9893] Optimized code InLongMsg.java

#9893

Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications
Describe the modifications you've done.

Comment thread inlong-common/src/main/java/org/apache/inlong/common/msg/InLongMsg.java Outdated
Copy link
Copy Markdown
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
Just left a comment, PTAL.

@beatCao beatCao requested a review from aloyszhang March 29, 2024 02:30
@dockerzhang
Copy link
Copy Markdown
Contributor

Run 'mvn spotless:apply' to fix the violations.

@aloyszhang aloyszhang added this to the 1.12.0 milestone Mar 29, 2024
@beatCao beatCao closed this Mar 29, 2024
@beatCao beatCao reopened this Mar 29, 2024
@beatCao
Copy link
Copy Markdown
Contributor Author

beatCao commented Mar 29, 2024

Run 'mvn spotless:apply' to fix the violations.

Problem fixed

Comment thread inlong-common/src/main/java/org/apache/inlong/common/msg/InLongMsg.java Outdated
@beatCao beatCao requested a review from aloyszhang March 29, 2024 04:01
@beatCao beatCao removed their assignment Mar 29, 2024
@dockerzhang
Copy link
Copy Markdown
Contributor

@beatCao you could keep the PR open, you do not need to open and close it again.

Copy link
Copy Markdown
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beatCao beatCao requested a review from aloyszhang March 31, 2024 05:56
@aloyszhang
Copy link
Copy Markdown
Contributor

aloyszhang commented Mar 31, 2024

image @beatCao , Hi, no more review is required from one committer or PMC member if he has approved before. Please feel free to ping other reviewers.

@dockerzhang dockerzhang merged commit 595bb12 into apache:master Mar 31, 2024
@beatCao beatCao deleted the INLONG-9893 branch April 1, 2024 02:04
castorqin pushed a commit to castorqin/inlong that referenced this pull request Apr 2, 2024
Co-authored-by: wangsong18@lenovo.com <wangsong18@lenovo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants