Skip to content

[INLONG-9884][Manager] Optimized code AuditServiceImpl#9896

Merged
dockerzhang merged 1 commit intoapache:masterfrom
balloon72:INLONG-9884
Mar 29, 2024
Merged

[INLONG-9884][Manager] Optimized code AuditServiceImpl#9896
dockerzhang merged 1 commit intoapache:masterfrom
balloon72:INLONG-9884

Conversation

@balloon72
Copy link
Copy Markdown
Contributor

Title Name: [INLONG-9884][Manager] Optimized code AuditServiceImpl

#9884

Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications
Describe the modifications you've done.

@aloyszhang
Copy link
Copy Markdown
Contributor

aloyszhang commented Mar 29, 2024

@balloon72 Thanks for your contribution!
This is a code-optimization type pull request same as #9888. Other places may also have the same problem. There will be too many issues and pull requests if we resolve them individually, also, it's hard to track all the issues.

So, I recommend bringing an umbrella issue to track all the code optimization issues at the module or sub-module level, each module or sub-module has only one issue to deal with the code optimization.

WDYT? Please feel free to share your opinions.

@balloon72
Copy link
Copy Markdown
Contributor Author

Great idea, I completely agree with this approach. Next time, I will create an umbrella issue to track code optimization problems.

@dockerzhang dockerzhang requested a review from fuweng11 March 29, 2024 05:04
@dockerzhang dockerzhang merged commit 6477e99 into apache:master Mar 29, 2024
@aloyszhang aloyszhang added this to the 1.12.0 milestone Apr 1, 2024
castorqin pushed a commit to castorqin/inlong that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants