Validate tsfiles after compaction #10146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingtanzjr
reviewed
Jun 14, 2023
| CompactionValidator validator = CompactionValidator.getInstance(); | ||
| if (!validator.validateCompaction( | ||
| tsFileManager, targetTsFileList, storageGroupName, timePartition)) { | ||
| LOGGER.error( |
Contributor
There was a problem hiding this comment.
Add more logs to illustrate why the validation is false.
xingtanzjr
reviewed
Jun 14, 2023
| } | ||
|
|
||
| @Override | ||
| public boolean validateCompaction( |
Contributor
There was a problem hiding this comment.
Maybe this method can return a class such as ValidationResult to represent the validation-result and detailed message if the validation is false. So that the invoker can add more error handle logic when validation is not passed such as print detailed logs
xingtanzjr
reviewed
Jun 14, 2023
.../src/main/java/org/apache/iotdb/db/engine/compaction/constant/CompactionValidationLevel.java
Show resolved
Hide resolved
THUMarkLau
pushed a commit
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add configuration item 'compaction_validation_level'.