Skip to content

[To rel/1.2] Forbid GROUP BY TAG query on views #10238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiaojialin merged 1 commit into from
Jun 20, 2023
Merged

[To rel/1.2] Forbid GROUP BY TAG query on views #10238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/AnalyzeVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,13 @@ public Analysis visitQuery(QueryStatement queryStatement, MPPQueryContext contex

// make sure paths in logical view is fetched
updateSchemaTreeByViews(analysis, schemaTree);
if (analysis.useLogicalView() && queryStatement.isAlignByDevice()) {
throw new SemanticException("Views cannot be used in ALIGN BY DEVICE query yet.");
if (analysis.useLogicalView()) {
if (queryStatement.isAlignByDevice()) {
throw new SemanticException("Views cannot be used in ALIGN BY DEVICE query yet.");
}
if (queryStatement.isGroupByTag()) {
throw new SemanticException("Views cannot be used in GROUP BY TAGS query yet.");
}
}
} finally {
logger.debug("[EndFetchSchema]");
Expand Down