Fix using too much memory when estimate compaction task memory#10619
Merged
HTHou merged 6 commits intoapache:masterfrom Jan 11, 2024
Merged
Conversation
This was referenced Jul 20, 2023
shuwenwei
force-pushed
the
fix-oom-when-estimate-cross-space-compaction-memory
branch
from
e5fa9e6 to
9e0a05a
Compare
caozj1011
approved these changes
Nov 23, 2023
shuwenwei
changed the title
shuwenwei
changed the title
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The memory estimation of compaction task need to scan all chunk metadata of selected files, and the method getAllTimeseriesMetadata() used by it may acquire too much memory. This pr fix it by using the iterator to read the metadata at measurement level.