factor the mods file size into the cross-space merge memory estimate#10668
Merged
xingtanzjr merged 1 commit intoapache:masterfrom Jul 25, 2023
Merged
factor the mods file size into the cross-space merge memory estimate#10668xingtanzjr merged 1 commit intoapache:masterfrom
xingtanzjr merged 1 commit intoapache:masterfrom
Conversation
xingtanzjr
approved these changes
Jul 24, 2023
caozj1011
added a commit
to caozj1011/iotdb
that referenced
this pull request
Aug 22, 2023
(cherry picked from commit 5bb6362)
caozj1011
added a commit
to caozj1011/iotdb
that referenced
this pull request
Aug 23, 2023
(cherry picked from commit 5bb6362)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the existing memory estimation method, the memory estimation required for seq files,unSeq files, and target files is estimated respectively. The mods file size of the source file is not factored into the memory estimate. This optimization takes the mods file size into account in memory estimates. See the documentation for details:https://apache-iotdb.feishu.cn/docx/UTkZd9ynbo99o6xuzNVc90wlnxg