Skip to content

Allow \*\`` in DevicePath#10901

Merged
JackieTien97 merged 5 commits intomasterfrom
CannotFetchSchemaPartition
Oct 9, 2023
Merged

Allow \*\`` in DevicePath#10901
JackieTien97 merged 5 commits intomasterfrom
CannotFetchSchemaPartition

Conversation

@JackieTien97
Copy link
Contributor

@JackieTien97 JackieTien97 commented Aug 18, 2023

* doesn't mean *, so use String.constains to do that judgement is incorrect. Actually, we don't need to do that if statement at all in write case.

to replay, you can simply use the following sql:

insert into root.db.`d1*2`(time,s1) values(1,1);

@JackieTien97 JackieTien97 changed the title Allow * in DevicePath Allow * in DevicePath Aug 18, 2023
@JackieTien97 JackieTien97 changed the title Allow * in DevicePath Allow \*\`` in DevicePath Aug 18, 2023
@JackieTien97 JackieTien97 changed the title Allow \*\`` in DevicePath Allow "*" in DevicePath Aug 18, 2023
@JackieTien97 JackieTien97 changed the title Allow "*" in DevicePath Allow \*\`` in DevicePath Aug 18, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

Merging #10901 (65a9cfe) into master (4d38980) will increase coverage by 0.00%.
The diff coverage is 40.00%.

@@            Coverage Diff            @@
##             master   #10901   +/-   ##
=========================================
  Coverage     48.56%   48.56%           
- Complexity    24140    24143    +3     
=========================================
  Files          2792     2792           
  Lines        171028   171028           
  Branches      20424    20424           
=========================================
+ Hits          83054    83055    +1     
+ Misses        87974    87973    -1     
Files Coverage Δ
...e/plan/analyze/cache/partition/PartitionCache.java 68.26% <100.00%> (+0.09%) ⬆️
...apache/iotdb/confignode/manager/ConfigManager.java 0.32% <0.00%> (+<0.01%) ⬆️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JackieTien97 JackieTien97 merged commit e929cee into master Oct 9, 2023
@JackieTien97 JackieTien97 deleted the CannotFetchSchemaPartition branch October 9, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants