Skip to content

Feature/streamlined grafana plugin profile#10907

Merged
HTHou merged 9 commits intoapache:masterfrom
chrisdutz:feature/streamlined-grafana-plugin-profile
Aug 24, 2023
Merged

Feature/streamlined grafana plugin profile#10907
HTHou merged 9 commits intoapache:masterfrom
chrisdutz:feature/streamlined-grafana-plugin-profile

Conversation

@chrisdutz
Copy link
Contributor

Till now the way the grafana plugin was added to the main project reactor was different to that of the other optional modules.

With this PR it matches that of the others.

@HTHou
Copy link
Contributor

HTHou commented Aug 24, 2023

cd $go_path/pkg/mod/github.com/magefile/mage@v1.14.0
chmod 755 $go_path/pkg/mod/github.com/magefile/*
go run $go_path/pkg/mod/github.com/magefile/mage@v1.14.0/bootstrap.go

To fix the error, you may need to modify these lines about version.

@chrisdutz
Copy link
Contributor Author

Good catch ... but a bit odd as previously it was 1.13.0 ... so in that case it couldn't have worked with 1.14.0 in the script.

@HTHou
Copy link
Contributor

HTHou commented Aug 24, 2023

Should we also move this in the pom.xml file of distribution to a profile, just like we do for cpp client?

iotdb/distribution/pom.xml

Lines 112 to 117 in e9fe0b1

<dependency>
<groupId>org.apache.iotdb</groupId>
<artifactId>iotdb-grafana-plugin</artifactId>
<version>${project.version}</version>
<type>pom</type>
</dependency>

@HTHou HTHou merged commit 489be30 into apache:master Aug 24, 2023
xuanronaldo pushed a commit to xuanronaldo/iotdb that referenced this pull request Aug 25, 2023
@chrisdutz chrisdutz deleted the feature/streamlined-grafana-plugin-profile branch June 7, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants