Feature/streamlined grafana plugin profile#10907
Merged
HTHou merged 9 commits intoapache:masterfrom Aug 24, 2023
Merged
Conversation
Contributor
|
iotdb/iotdb-connector/grafana-plugin/backend-compile.sh Lines 31 to 33 in e9fe0b1 To fix the error, you may need to modify these lines about version. |
Contributor
Author
|
Good catch ... but a bit odd as previously it was 1.13.0 ... so in that case it couldn't have worked with 1.14.0 in the script. |
Contributor
|
Should we also move this in the pom.xml file of distribution to a profile, just like we do for cpp client? Lines 112 to 117 in e9fe0b1 |
…ed-grafana-plugin-profile
HTHou
reviewed
Aug 24, 2023
…ed-grafana-plugin-profile
HTHou
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Till now the way the grafana plugin was added to the main project reactor was different to that of the other optional modules.
With this PR it matches that of the others.