Skip to content

[IOTDB-6142] Pipe: Implemented IoTDBOpcUaConnector to enable transfer using Opc Ua protocol#10976

Merged
SteveYurongSu merged 20 commits intoapache:masterfrom
Caideyipi:OPCUAConnector
Sep 7, 2023
Merged

[IOTDB-6142] Pipe: Implemented IoTDBOpcUaConnector to enable transfer using Opc Ua protocol#10976
SteveYurongSu merged 20 commits intoapache:masterfrom
Caideyipi:OPCUAConnector

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

@Caideyipi Caideyipi commented Aug 28, 2023

IOTDB-6142

Enabled data sending to subscriber clients through Opc Ua protocol.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

# Conflicts:
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/config/constant/PipeConnectorConstant.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/task/subtask/connector/PipeConnectorSubtaskManager.java
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/plugin/builtin/BuiltinPipePlugin.java
@Caideyipi Caideyipi changed the title Pipe: Implemented IoTDBOpcUaConnector to enable transfer in Opc Ua protocol Pipe: Implemented IoTDBOpcUaConnector to enable transfer using Opc Ua protocol Aug 28, 2023
@SteveYurongSu SteveYurongSu self-requested a review August 30, 2023 16:47
@SteveYurongSu SteveYurongSu self-assigned this Aug 30, 2023
# Conflicts:
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/airgap/IoTDBAirGapConnector.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/async/IoTDBThriftAsyncConnector.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBThriftSyncConnector.java
Copy link
Copy Markdown
Collaborator Author

@Caideyipi Caideyipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Copy link
Copy Markdown
Member

@SteveYurongSu SteveYurongSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Caideyipi Caideyipi changed the title Pipe: Implemented IoTDBOpcUaConnector to enable transfer using Opc Ua protocol [IOTDB-6142] Pipe: Implemented IoTDBOpcUaConnector to enable transfer using Opc Ua protocol Sep 7, 2023
@SteveYurongSu SteveYurongSu merged commit 54e1140 into apache:master Sep 7, 2023
Caideyipi added a commit to Caideyipi/iotdb that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants