Fixed write rejection when wal size exceeds threshold#10993
Merged
xingtanzjr merged 1 commit intoapache:masterfrom Aug 31, 2023
Merged
Fixed write rejection when wal size exceeds threshold#10993xingtanzjr merged 1 commit intoapache:masterfrom
xingtanzjr merged 1 commit intoapache:masterfrom
Conversation
xingtanzjr
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the wal file disk size exceeds 50G x 0.8, the flush or snapshot logic will be triggered. However, when the active memtable is large enough, the snapshot or flush speed will always be lower than the new generation speed, so the write is always refused. The fix determines that if the threshold is exceeded, the snapshot or flush operation continues until the disk size is below the threshold. In addition, also changed the judgment conditions, the return from
trySnapshotOrFlushMemTablereturn after failure to success