Merged
Conversation
HTHou
approved these changes
Sep 6, 2023
HTHou
pushed a commit
that referenced
this pull request
Sep 27, 2023
* fix: Hopefully fixed the build of the cpp-example on windows systems * refactor: Made the MQTT Message take Object instead of just String types. * fix: Made the grafana-plugin build fail, if the ant tasks for compiling fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #11042
Turns out that on some systems the GOROOT variable wrapps the path in double quotes, but some newer systems these are wrapped by single quotes. So I added a second sed-replace that simply strips the variable of all single quotes.
Besides that I told the tasks in the maven-antrun-plugin configuration to fail the build, if the execution fails, this way we shouldn't miss issues like this in the future.