Pipe: introduce global cache for TsFile metadatas and support TTL of Pipe TsFile#11240
Merged
SteveYurongSu merged 23 commits intoapache:masterfrom Nov 23, 2023
Merged
Conversation
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/wal/PipeWALResource.java
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/TsFileInsertionDataContainer.java
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/concurrent/ThreadName.java
Show resolved
Hide resolved
...src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/TsFileInsertionDataContainer.java
Outdated
Show resolved
Hide resolved
Caideyipi
approved these changes
Nov 20, 2023
Collaborator
Caideyipi
left a comment
Caideyipi
left a comment
There was a problem hiding this comment.
No other problems spotted ;-)
...src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/TsFileInsertionDataContainer.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/tsfile/PipeTsFileResource.java
Outdated
Show resolved
Hide resolved
Caideyipi
reviewed
Nov 22, 2023
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/tsfile/PipeTsFileResource.java
Show resolved
Hide resolved
Caideyipi
reviewed
Nov 22, 2023
...tanode/src/main/java/org/apache/iotdb/db/pipe/resource/tsfile/PipeTsFileResourceManager.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/tsfile/PipeTsFileResource.java
Show resolved
Hide resolved
DanielWang2035
changed the title
SteveYurongSu
approved these changes
Nov 23, 2023
Member
SteveYurongSu
left a comment
SteveYurongSu
left a comment
There was a problem hiding this comment.
WELL WELL DONE! WHAT A WONDERFUL JOB!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a TsFile is processed by N pipes, its metadata will be constructed N times, the overhead will be high when N is very big. This PR added a global cache to reduce repeated creation and redundant IO.
This PR also introduces TTL of TsFiles pinned by pipe engine, just like WALs.