Skip to content

Fix the problem of inaccurate GC monitor detection at the beginning and adjusting the alert threshold.#11297

Merged
OneSizeFitsQuorum merged 44 commits intoapache:masterfrom
Pengzna:metric/jvm
Oct 13, 2023
Merged

Fix the problem of inaccurate GC monitor detection at the beginning and adjusting the alert threshold.#11297
OneSizeFitsQuorum merged 44 commits intoapache:masterfrom
Pengzna:metric/jvm

Conversation

@Pengzna
Copy link
Collaborator

@Pengzna Pengzna commented Oct 12, 2023 •
edited by OneSizeFitsQuorum
Loading

  1. Fix the problem of inaccurate GC monitor detection at the beginning.
  • When the Metric Service starts after the jvm, the gc time before the Metric Service is started will also be counted, causing the GC percentage within the initial time window to be significantly higher than expected, as shown in this figure:
修复前
  • Fix this bug by only calculating GC time within the time window. The effect after fixing this bug is shown in this figure:
修复后
  1. Lowered the gc percentage alert threshold from 50% to 30%.

Pengzna and others added 30 commits July 20, 2023 09:55
@Pengzna
Add jvm gc monitor and alerter
8cd2278
@Pengzna
Fix concurrent GC duration calculation
6fc2282
@Pengzna
Merge remote-tracking branch 'origin/master'
dc61e20
Reformat codes with IoTDB's standard.
6f17647
Reformat gc_pause_{cause} naming style.
7b5247e
@Pengzna
Merge branch 'apache:master' into master
a8772b1
adding license.
d8af94d
add metric remove and some comments
1b4a6f5
remove end-of-line comment
b841b55
Merge remote-tracking branch 'base/master'
9281355 
# Conflicts:
#	iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java
merge base iotdb
6042b27
@Pengzna
Merge branch 'apache:master' into master
3428dd4
add thread name
771d35d
Merge remote-tracking branch 'base/master'
db909e1 
# Conflicts:
#	iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/metricsets/jvm/JvmGcMetrics.java
spotless apply
4dff86d
rename and add some comments
c71517f
add some detailed comments
ae79618
@Pengzna
Merge branch 'apache:master' into master
26d21a2
fix global previousTotal var
c477c80
fix review of ThreadName
bc6f0bf
remove duplicate metrics throughout
fbb3562
fix review 1-4
84a78a3
remove duplicate
2fc18db
remove duplicate fields and add accumulated gc time within obsWindows
6cfae46
adjust max GC time threshold
15eaf43
@Pengzna
Merge branch 'apache:master' into master
5109116
Merge remote-tracking branch 'origin/master'
276f662
fix review
17f60e7
fix threshold
df8caa5
@Pengzna
Merge branch 'apache:master' into master
d5786f6
Pengzna and others added 14 commits July 28, 2023 16:12
OneSizeFitsQuorum
OneSizeFitsQuorum approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit b61f634 into apache:master Oct 13, 2023
Pengzna added a commit to Pengzna/iotdb that referenced this pull request Oct 13, 2023
@Pengzna
Fix the problem of inaccurate GC monitor detection at the beginning a…
c23dfc4 
…nd adjusting the alert threshold. (apache#11297)

(cherry picked from commit b61f634)
@Pengzna Pengzna mentioned this pull request Oct 13, 2023
Merged
OneSizeFitsQuorum pushed a commit that referenced this pull request Oct 13, 2023
@Pengzna
Fix the problem of inaccurate GC monitor detection at the beginning a…
ce41a15 
…nd adjusting the alert threshold. (#11297) (#11301)
@Pengzna Pengzna deleted the metric/jvm branch June 18, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pengzna @OneSizeFitsQuorum