Skip to content

Fixed Ratis server RPC timeout parameter setting invalidation bug#11418

Merged
OneSizeFitsQuorum merged 1 commit intomasterfrom
ratis_server_timeout
Oct 30, 2023
Merged

Fixed Ratis server RPC timeout parameter setting invalidation bug#11418
OneSizeFitsQuorum merged 1 commit intomasterfrom
ratis_server_timeout

Conversation

@OneSizeFitsQuorum
Copy link
Copy Markdown
Contributor

Phenomenon:

  • Our Ratis RPC timeout parameter is only applied to the Client, not to the Server.
  • This results in the following RPC timeout still being 3s, which we actually set to 10s in the parameter
    img_v2_c21a223f-119b-4262-8fae-b9cad8f44bcg

Solution:

  • Set the corresponding parameters when starting the Ratis Server

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #11418 (2a75101) into master (b13edf3) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #11418      +/-   ##
============================================
- Coverage     48.57%   48.56%   -0.01%     
+ Complexity    24451    24449       -2     
============================================
  Files          2817     2817              
  Lines        173143   173144       +1     
  Branches      20672    20672              
============================================
- Hits          84100    84094       -6     
- Misses        89043    89050       +7     
Files Coverage Δ
.../org/apache/iotdb/consensus/ratis/utils/Utils.java 99.34% <100.00%> (+<0.01%) ⬆️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit f3e0f35 into master Oct 30, 2023
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the ratis_server_timeout branch October 30, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants