PBTree: Logging Disabled with Ratis and Pre-Allocation Disabled for devices using template#11467
Merged
MarcosZyk merged 9 commits intoapache:masterfrom Nov 7, 2023
Merged
Conversation
MarcosZyk
approved these changes
Nov 3, 2023
HTHou
pushed a commit
that referenced
this pull request
Dec 20, 2023
…evices using template (#11467)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PBTree Logging
Previously, PBTree employed a double-buffering-like log mechanism to ensure file integrity. However, this has become redundant under Ratis consensus, where integrity is assured through snapshots and Ratis logs. Now, PBTree no longer logs under Ratis consensus.
Pre-Allocation
In its initial design, PBTree would pre-allocate a segment (consider it a buffer for child nodes) for the Internal/Device child of the incoming node, reducing overhead of parental pointer updates when the child is passed in. This mechanism remains effective, except for device nodes using templates, as they no longer have any children.