Skip to content

Pipe IT: Fix WALFlushListener.testConcurrentGetValue() & Fix smells reported by sonar #11525

Merged
SteveYurongSu merged 10 commits intoapache:masterfrom
Caideyipi:sonar-bin-2!
Nov 14, 2023
Merged

Pipe IT: Fix WALFlushListener.testConcurrentGetValue() & Fix smells reported by sonar #11525
SteveYurongSu merged 10 commits intoapache:masterfrom
Caideyipi:sonar-bin-2!

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

@Caideyipi Caideyipi commented Nov 13, 2023 •
edited
Loading

Description

This PR has avoided the hard coding of WAL cache logging, and fixed the UT of concurrentGet.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title Sonar bin 2! Pipe: Fixed IT style / Sonar bugs reported Nov 13, 2023
@SteveYurongSu SteveYurongSu self-assigned this Nov 13, 2023
@Caideyipi Caideyipi changed the title Pipe: Fixed IT style / Sonar bugs reported Pipe: Refactored the pipe code and fixed the wal UT problem to avoid terminate waiting of wal node ready in advance Nov 14, 2023
@SteveYurongSu SteveYurongSu changed the title Pipe: Refactored the pipe code and fixed the wal UT problem to avoid terminate waiting of wal node ready in advance Pipe IT: Fix WALFlushListener.testConcurrentGetValue() & Avoid hard coding the nodes num and consensus config in IoTDBPipeClusterIT Nov 14, 2023
@SteveYurongSu SteveYurongSu changed the title Pipe IT: Fix WALFlushListener.testConcurrentGetValue() & Avoid hard coding the nodes num and consensus config in IoTDBPipeClusterIT Pipe IT: Fix WALFlushListener.testConcurrentGetValue() Nov 14, 2023
@SteveYurongSu SteveYurongSu changed the title Pipe IT: Fix WALFlushListener.testConcurrentGetValue() Pipe IT: Fix WALFlushListener.testConcurrentGetValue() & Fix smells reported by sonar Nov 14, 2023
@SteveYurongSu SteveYurongSu merged commit 6bb3d93 into apache:master Nov 14, 2023
HTHou pushed a commit that referenced this pull request Dec 20, 2023
@Caideyipi @HTHou
Pipe IT: Fix WALFlushListener.testConcurrentGetValue() & Fix smells r…
3f6ac9a 
…eported by sonar (#11525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yschengzi yschengzi yschengzi left review comments

Assignees

@SteveYurongSu SteveYurongSu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Caideyipi @yschengzi @SteveYurongSu