Skip to content

Pipe IT: Enable Pipe IT to tolerate failures caused by resource shortage#11527

Merged
SteveYurongSu merged 5 commits intoapache:masterfrom
Caideyipi:flush-fix
Nov 14, 2023
Merged

Pipe IT: Enable Pipe IT to tolerate failures caused by resource shortage#11527
SteveYurongSu merged 5 commits intoapache:masterfrom
Caideyipi:flush-fix

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

@Caideyipi Caideyipi commented Nov 13, 2023

Description

Now due to the limitation of github machine resource, the pipe IT may fail occasionally because the write, read, and flush may run into problem because resource shortage. This PR ignore the failure of flush and write and just return success,
and keep retrying even if the read operation falls into an exception, since in this case pipe cannot provide consistency even in the real scene.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title Flush fix Pipe: changed the pipe IT logic to permit failure of flush Nov 13, 2023
@Caideyipi Caideyipi changed the title Pipe: changed the pipe IT logic to permit failure of flush Pipe: changed the pipe IT logic to tolerate failures caused by resource shortage Nov 13, 2023
@Caideyipi Caideyipi changed the title Pipe: changed the pipe IT logic to tolerate failures caused by resource shortage Pipe: Enable Pipe IT to tolerate failures caused by resource shortage Nov 13, 2023
@SteveYurongSu SteveYurongSu self-assigned this Nov 13, 2023
@SteveYurongSu SteveYurongSu changed the title Pipe: Enable Pipe IT to tolerate failures caused by resource shortage Pipe IT: Enable Pipe IT to tolerate failures caused by resource shortage Nov 14, 2023
@SteveYurongSu SteveYurongSu merged commit 070a514 into apache:master Nov 14, 2023
@Caideyipi Caideyipi deleted the flush-fix branch November 14, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants