Conversation
|
Kudos, SonarCloud Quality Gate passed! |
| public static void setMaxRunTime(Duration maxRunTime) { | ||
| OperatorContext.maxRunTime = maxRunTime; |
There was a problem hiding this comment.
why not remove this method since it is now only used in tests and ClientRpcServiceImpl? I think there's no need to call this method both in tests and ClientRpcServiceImpl, too.
There was a problem hiding this comment.
Actually, I wanna keep this method for future usage like we want to change the time slice for running DN without restarting it.
There was a problem hiding this comment.
If I'm not mistaken, changing the time slice length without restarting should be done through calling a Session interface or executing a SQL . However, setting OperatorMaxRuntime doesn't seem to work, and it seems that what should be changed is the value in the Config, right?
There was a problem hiding this comment.
Yes, but in current situation, each operator's max run time is got from OperatorContext. And calling a Session interface or executing a SQL is to change the value in OperatorContext.
2 participants
We never need to split the time slice for each operator in one DriverTask because we're using pull-based execution model, even if one child consume all the time slice of one dirver, its parent should detect that and then stop current run immediately instead of keeping runing next child operator.