Skip to content

Fix explain error when align by device + template#11610

Merged
JackieTien97 merged 1 commit intomasterfrom
beyyes/fix_explain
Nov 24, 2023
Merged

Fix explain error when align by device + template#11610
JackieTien97 merged 1 commit intomasterfrom
beyyes/fix_explain

Conversation

@Beyyes
Copy link
Member

@Beyyes Beyyes commented Nov 23, 2023

Description

Before fix, the explain result of below sql list is empty.

CREATE database root.sg2; CREATE schema template t2 aligned (s1 FLOAT encoding=RLE, s2 BOOLEAN encoding=PLAIN compression=SNAPPY, s3 INT32); SET SCHEMA TEMPLATE t2 to root.sg2; INSERT INTO root.sg2.d1(timestamp,s1,s2,s3) values(1,1.1,false,1), (2,2.2,false,2); INSERT INTO root.sg2.d2(timestamp,s1,s2,s3) values(1,11.1,false,11), (2,22.2,false,22); INSERT INTO root.sg2.d3(timestamp,s1,s2,s3) values(1,111.1,true,null), (4,444.4,true,44); INSERT INTO root.sg2.d4(timestamp,s1,s2,s3) values(1,1111.1,true,1111), (5,5555.5,false,5555); SELECT * FROM root.sg2.** ALIGN BY DEVICE;

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0f18f38) 48.92% compared to head (eeed5da) 48.94%.
Report is 5 commits behind head on master.

Files Patch % Lines
...execution/memory/StatementMemorySourceVisitor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11610      +/-   ##
============================================
+ Coverage     48.92%   48.94%   +0.02%     
- Complexity    24860    24879      +19     
============================================
  Files          2800     2800              
  Lines        175526   175572      +46     
  Branches      21094    21101       +7     
============================================
+ Hits          85872    85939      +67     
+ Misses        89654    89633      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit dcb6d8e into master Nov 24, 2023
@JackieTien97 JackieTien97 deleted the beyyes/fix_explain branch November 24, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants