[RatisConsensus] Cache group id in the write/read critical path#11615
Merged
OneSizeFitsQuorum merged 2 commits intoapache:masterfrom Nov 29, 2023
Merged
[RatisConsensus] Cache group id in the write/read critical path#11615OneSizeFitsQuorum merged 2 commits intoapache:masterfrom
OneSizeFitsQuorum merged 2 commits intoapache:masterfrom
Conversation
| private static final String SCHEMA_REGION_GROUP = "group-0002"; | ||
| private static final CommonConfig config = CommonDescriptor.getInstance().getConfig(); | ||
| private static final Cache<ConsensusGroupId, RaftGroupId> cache = | ||
| CacheBuilder.newBuilder().weakValues().build(); |
Contributor
There was a problem hiding this comment.
Add the default expiration time of 5min? This will also work in the future with region migrations
Member
Author
There was a problem hiding this comment.
Captain, oh my captain!
OneSizeFitsQuorum
approved these changes
Nov 29, 2023
Contributor
OneSizeFitsQuorum
left a comment
OneSizeFitsQuorum
left a comment
There was a problem hiding this comment.
LGTM~
Thanks William for this detailed optimization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to compute the consensus group id to raft group id mapping every time. This is cpu-consuming and we can avoid them simply by adding a weak-value cache.