Use min(limt, page size) as the init capacity of result block#11619
Merged
JackieTien97 merged 2 commits intomasterfrom Nov 27, 2023
Merged
Use min(limt, page size) as the init capacity of result block#11619JackieTien97 merged 2 commits intomasterfrom
JackieTien97 merged 2 commits intomasterfrom
Conversation
|
SonarCloud Quality Gate failed.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11619 +/- ##
=========================================
Coverage 49.00% 49.01%
- Complexity 24883 24889 +6
=========================================
Files 2810 2810
Lines 175991 176002 +11
Branches 21116 21116
=========================================
+ Hits 86250 86266 +16
+ Misses 89741 89736 -5 ☔ View full report in Codecov by Sentry. |
Beyyes
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some query cases, of the limit is much less than the count of each page, we should use limit instead of page size as the init capacity of the result block.