Skip to content

Fix concurrent bug in PartitonCache#11622

Merged
JackieTien97 merged 3 commits intomasterfrom
PartitionCacheBug
Nov 27, 2023
Merged

Fix concurrent bug in PartitonCache#11622
JackieTien97 merged 3 commits intomasterfrom
PartitionCacheBug

Conversation

@JackieTien97
Copy link
Contributor

more details can be seen in https://jira.infra.timecho.com:8443/browse/TIMECHODB-447

we can find that if the cache is cleared between these two line, we will try to create an already existing database.

img_v3_0258_cc4d98db-8808-4bd1-bc97-2828b309e3eg

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b5214cb) 49.00% compared to head (65363a3) 49.00%.
Report is 2 commits behind head on master.

Files Patch % Lines
...e/plan/analyze/cache/partition/PartitionCache.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11622   +/-   ##
=========================================
  Coverage     49.00%   49.00%           
- Complexity    24883    24890    +7     
=========================================
  Files          2810     2810           
  Lines        175991   175991           
  Branches      21116    21116           
=========================================
+ Hits          86250    86251    +1     
+ Misses        89741    89740    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackieTien97 JackieTien97 merged commit f34e950 into master Nov 27, 2023
@JackieTien97 JackieTien97 deleted the PartitionCacheBug branch November 27, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants