Skip to content

Fix npe in TopKOperator when topKResult is null.#11627

Merged
JackieTien97 merged 1 commit intomasterfrom
beyyes/fix_dop
Nov 29, 2023
Merged

Fix npe in TopKOperator when topKResult is null.#11627
JackieTien97 merged 1 commit intomasterfrom
beyyes/fix_dop

Conversation

@Beyyes
Copy link
Member

@Beyyes Beyyes commented Nov 28, 2023

Description

Fix the possible npe in TopKOperator when the children device operators of TopKOperator all have no result.

img_v3_025j_a35983bd-a75b-4503-981d-ddfc902b1f2g

img_v3_025j_f3dd9da3-7018-447c-828b-f74d7c38df6g

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1a52ca3) 49.00% compared to head (55daa6f) 49.04%.
Report is 2 commits behind head on master.

Files Patch % Lines
.../db/queryengine/plan/analyze/TemplatedAnalyze.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11627      +/-   ##
============================================
+ Coverage     49.00%   49.04%   +0.03%     
- Complexity    24884    24900      +16     
============================================
  Files          2810     2810              
  Lines        176002   176005       +3     
  Branches      21116    21116              
============================================
+ Hits          86253    86322      +69     
+ Misses        89749    89683      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit 259d3fc into master Nov 29, 2023
@JackieTien97 JackieTien97 deleted the beyyes/fix_dop branch November 29, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants