Skip to content

Fix compaction selector ut running time is too long #11635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HTHou merged 2 commits into from
Nov 29, 2023
Merged

Fix compaction selector ut running time is too long #11635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7814550
add validate file is exist, avoid rename error.
caozj1011 Nov 29, 2023
fb157f9
fixed ut taking too long
caozj1011 Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions .../iotdb/db/storageengine/dataregion/compaction/inner/InnerSpaceCompactionSelectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,12 @@
import org.junit.Test;
import org.mockito.Mockito;

import java.io.File;
import java.io.IOException;
import java.util.List;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.atomic.AtomicBoolean;

import static org.apache.iotdb.tsfile.common.constant.TsFileConstant.PATH_SEPARATOR;

public class InnerSpaceCompactionSelectorTest extends AbstractCompactionTest {
@Before
public void setUp()
Expand Down Expand Up @@ -673,25 +672,37 @@ public void testSelectWhenModsFileGreaterThan50M()
tsFileManager.addAll(seqResources, true);
tsFileManager.addAll(unseqResources, false);

TsFileResource tsFileResource = seqResources.get(0);

ModificationFile modFile = tsFileResource.getModFile();

while (modFile.getSize() < 1024 * 1024 * 50) {
modFile.write(
new Deletion(
new PartialPath(COMPACTION_TEST_SG + PATH_SEPARATOR + "**"),
Long.MIN_VALUE,
Long.MAX_VALUE));
}

// mock modification file size must greater than 50M
MockModiFicationFile mockModiFicationFile =
new MockModiFicationFile(
seqResources.get(0).getTsFilePath() + ModificationFile.FILE_SUFFIX);
mockModiFicationFile.write(new Deletion(new PartialPath("root.a.b"), 1, 1));
seqResources.get(0).setModFile(mockModiFicationFile);
SizeTieredCompactionSelector selector =
new SizeTieredCompactionSelector("", "", 0, true, tsFileManager);
// copy candidate source file list
List<TsFileResource> resources = tsFileManager.getOrCreateSequenceListByTimePartition(0);
List<InnerSpaceCompactionTask> innerSpaceCompactionTasks =
selector.selectInnerSpaceTask(resources);
Assert.assertEquals(1, innerSpaceCompactionTasks.size());
modFile.remove();
mockModiFicationFile.remove();
}

class MockModiFicationFile extends ModificationFile {

/**
* Construct a ModificationFile using a file as its storage.
*
* @param filePath the path of the storage file.
*/
public MockModiFicationFile(String filePath) {
super(filePath);
new File(filePath);
}

@Override
public long getSize() {
return 1024 * 1024 * 50 + 1;
}
}
}