Skip to content

[IOTDB-6260] Pipe: Wait for the hardlink/copied tsfile to finish being transfered before deleting #11637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MiniSho wants to merge 1 commit into from
Closed

[IOTDB-6260] Pipe: Wait for the hardlink/copied tsfile to finish being transfered before deleting #11637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion ...e/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/tsfile/PipeTsFileResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import java.io.File;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -121,11 +122,36 @@ public synchronized void close() throws IOException {
allocatedMemoryBlock = null;
}

Files.deleteIfExists(hardlinkOrCopiedFile.toPath());
deleteFileWithRetry(hardlinkOrCopiedFile.toPath());

LOGGER.info("PipeTsFileResource: Closed tsfile {} and cleaned up.", hardlinkOrCopiedFile);
}

private void deleteFileWithRetry(Path path) throws IOException {
final int maxRetries = 10;
final long waitIntervalInMs = 5000;

for (int i = 0; i < maxRetries; i++) {
try {
if (Files.deleteIfExists(path)) {
return;
}
} catch (IOException e) {
LOGGER.warn("Delete file failed, retrying... (" + (i + 1) + "/" + maxRetries + ")", e);
}

try {
Thread.sleep(waitIntervalInMs * i);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new IOException("Interrupted while deleting tsfile: " + path, e);
}
}

LOGGER.error("Failed to delete file, max retry times reached: " + path);
throw new IOException("Failed to delete file: " + path);
}

//////////////////////////// Cache Getter ////////////////////////////

public synchronized Map<String, List<String>> tryGetDeviceMeasurementsMap() throws IOException {
Expand Down