Skip to content

Add close method for TopKOperator#11649

Closed
Beyyes wants to merge 1 commit intomasterfrom
beyyes/add_close_for_topkoperator
Closed

Add close method for TopKOperator#11649
Beyyes wants to merge 1 commit intomasterfrom
beyyes/add_close_for_topkoperator

Conversation

@Beyyes
Copy link
Member

@Beyyes Beyyes commented Nov 30, 2023

Description

No close method may cause memory leak.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2a1fad8) 49.03% compared to head (78735ec) 49.03%.

Files Patch % Lines
...ngine/execution/operator/process/TopKOperator.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11649   +/-   ##
=========================================
  Coverage     49.03%   49.03%           
- Complexity    24913    24917    +4     
=========================================
  Files          2815     2815           
  Lines        176137   176145    +8     
  Branches      21132    21133    +1     
=========================================
+ Hits          86360    86381   +21     
+ Misses        89777    89764   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Beyyes Beyyes closed this Nov 30, 2023
@Beyyes Beyyes deleted the beyyes/add_close_for_topkoperator branch December 12, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants