Skip to content

Pipe: Add pipeSinkHandshakeTimeout parameter to distinguish it from pipeSinkTransferTimeout & Call handshake() method of temporary connector's to validate createPipeStatement#11655

Merged
SteveYurongSu merged 13 commits intoapache:masterfrom
Caideyipi:parameter
Dec 13, 2023

Conversation

@Caideyipi
Copy link
Collaborator

@Caideyipi Caideyipi commented Dec 1, 2023

Description

Currently, pipe's handshake and transfer share one timeout, however, handshake requires less timeout to avoid timeout of procedure, and transfer requires more timeout to allow time-consuming loading of receiver's tsFiles.
Thus, this PR distinguished them apart, and refactored the parameters and syncClient logic.

This PR includes the following modifications:

  1. Separate pipe handshake and transfer timeOut and let the former one sooner.
  2. Added handshake logic to pipe SQL validation before the SQL reach ConfigNode.
  3. Moved the authIT to pipe ITs to prevent premature failure.
  4. TestUtils refactor.

Example:

create pipe sink_ip_invalid1 with source ('source'='iotdb-source', 'source.pattern'='root.aligned','source.history.enable'='false','source.realtime.enable'='true') with sink ('sink'='iotdb-thrift-sink', 'sink.ip'='127.0.0.0', 'sink.port'='6668');

create pipe sink_ip_invalid2 with source ('source'='iotdb-source', 'source.pattern'='root.aligned','source.history.enable'='false','source.realtime.enable'='true') with sink ('sink'='iotdb-thrift-sink', 'sink.ip'='1271', 'sink.port'='6668');

image

@SteveYurongSu SteveYurongSu self-assigned this Dec 2, 2023
@SteveYurongSu SteveYurongSu changed the title Pipe: Added pipeSinkHandshakeTimeout parameter to distinguish it from pipeSinkTransferTimeout Pipe: Add pipeSinkHandshakeTimeout parameter to distinguish it from pipeSinkTransferTimeout & Call handshake() method of temporary connector's to validate createPipeStatement Dec 12, 2023
@SteveYurongSu SteveYurongSu merged commit 63475a1 into apache:master Dec 13, 2023
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
…ipeSinkTransferTimeout & Call handshake() method of temporary connector's to validate createPipeStatement (apache#11655)

Currently, pipe's handshake and transfer share one timeout, however, handshake requires less timeout to avoid timeout of procedure, and transfer requires more timeout to allow time-consuming loading of receiver's tsFiles.
Thus, this commit distinguished them apart, and refactored the parameters and syncClient logic.

This commit includes the following modifications:
1. Separate pipe handshake and transfer timeOut and let the former one sooner.
2. Added handshake logic to pipe SQL validation before the SQL reach ConfigNode.
3. Moved the authIT to pipe ITs to prevent premature failure.
4. TestUtils refactor.

---------

Co-authored-by: Steve Yurong Su <rong@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants