Skip to content

Pipe Schema: Receiver Agent: config plan node to statement transformation logic#11689

Merged
SteveYurongSu merged 16 commits intoapache:masterfrom
Caideyipi:statementToPlanNode
Dec 16, 2023
Merged

Pipe Schema: Receiver Agent: config plan node to statement transformation logic#11689
SteveYurongSu merged 16 commits intoapache:masterfrom
Caideyipi:statementToPlanNode

Conversation

@Caideyipi
Copy link
Collaborator

@Caideyipi Caideyipi commented Dec 11, 2023 •
edited
Loading

Description

This PR includes the following modifications:

  1. Added PipePlanToStatementVisitor to parse the nodes to the statement (not including nodes corresponding to all delete operations and alterLogicalView).
  2. Added extra send logic for alterLogicalViewNode.
  3. Added config rpc and execution logic of the received configPlan bytes.(not completed yet)
  4. Added pipeEnrichedPlan to mark the received pipe plans.
  5. Deleted useless sink rpc logic of the previous versions.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title Pipe Schema: Added statement to planNode transfromation logic Pipe Schema: Added planNode to stateMent transfromation logic Dec 11, 2023
@Caideyipi Caideyipi changed the title Pipe Schema: Added planNode to stateMent transfromation logic Pipe Schema: Added planNode to statement transfromation logic Dec 11, 2023
@SteveYurongSu SteveYurongSu self-assigned this Dec 12, 2023
@Caideyipi Caideyipi changed the title Pipe Schema: Added planNode to statement transfromation logic Pipe Schema: Added planNode to statement transformation logic Dec 12, 2023
@SteveYurongSu SteveYurongSu changed the title Pipe Schema: Added planNode to statement transformation logic Pipe Schema: Receiver Agent: Added planNode to statement transformation logic Dec 13, 2023
@SteveYurongSu SteveYurongSu changed the title Pipe Schema: Receiver Agent: Added planNode to statement transformation logic Pipe Schema: Receiver Agent: config plan node to statement transformation logic Dec 16, 2023
SteveYurongSu
SteveYurongSu approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@SteveYurongSu SteveYurongSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@SteveYurongSu SteveYurongSu merged commit 40c3251 into apache:master Dec 16, 2023
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
@Caideyipi @SzyWilliam
Pipe Schema: Receiver Agent: config plan node to statement transforma…
822afdc 
…tion logic (apache#11689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveYurongSu SteveYurongSu SteveYurongSu approved these changes

Assignees

@SteveYurongSu SteveYurongSu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Caideyipi @SteveYurongSu