Make slimit and soffset available in align by device with template#11696
Merged
JackieTien97 merged 1 commit intomasterfrom Dec 12, 2023
Merged
Make slimit and soffset available in align by device with template#11696JackieTien97 merged 1 commit intomasterfrom
JackieTien97 merged 1 commit intomasterfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11696 +/- ##
=========================================
Coverage 49.10% 49.10%
- Complexity 24982 24990 +8
=========================================
Files 2817 2817
Lines 176773 176805 +32
Branches 21186 21200 +14
=========================================
+ Hits 86804 86827 +23
- Misses 89969 89978 +9 ☔ View full report in Codecov by Sentry. |
JackieTien97
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Before fix, slimit and soffset is invalid in align by device with template.
Now I add
ColumnPaginationControllerusage inTemplatedAnalyze.java. More details are shown in integration-tests.