Skip to content

Make slimit and soffset available in align by device with template#11696

Merged
JackieTien97 merged 1 commit intomasterfrom
beyyes/fix_align_by_device_slimit
Dec 12, 2023
Merged

Make slimit and soffset available in align by device with template#11696
JackieTien97 merged 1 commit intomasterfrom
beyyes/fix_align_by_device_slimit

Conversation

@Beyyes
Copy link
Member

@Beyyes Beyyes commented Dec 12, 2023

Description

Before fix, slimit and soffset is invalid in align by device with template.

Now I add ColumnPaginationController usage in TemplatedAnalyze.java. More details are shown in integration-tests.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (09b7e86) 49.10% compared to head (57be2f0) 49.10%.
Report is 3 commits behind head on master.

Files Patch % Lines
.../db/queryengine/plan/analyze/TemplatedAnalyze.java 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11696   +/-   ##
=========================================
  Coverage     49.10%   49.10%           
- Complexity    24982    24990    +8     
=========================================
  Files          2817     2817           
  Lines        176773   176805   +32     
  Branches      21186    21200   +14     
=========================================
+ Hits          86804    86827   +23     
- Misses        89969    89978    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackieTien97 JackieTien97 merged commit b57f320 into master Dec 12, 2023
@JackieTien97 JackieTien97 deleted the beyyes/fix_align_by_device_slimit branch December 12, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants