Pipe: enhance the idempotence of start / stop pipe #11713
Merged
SteveYurongSu merged 9 commits intoapache:masterfrom Dec 16, 2023
Merged
Pipe: enhance the idempotence of start / stop pipe #11713SteveYurongSu merged 9 commits intoapache:masterfrom
SteveYurongSu merged 9 commits intoapache:masterfrom
Conversation
This reverts commit 3abf32e.
VGalaxies
changed the title
VGalaxies
changed the title
Caideyipi
reviewed
Dec 14, 2023
...fignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/task/PipeTaskCoordinator.java
Show resolved
Hide resolved
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
As title. This commit is a follow-up to apache#11690, from now onwards, no-op start pipe and stop pipe will directly skip the entire procedure execution, avoiding the impact of rollback and other exceptional situations. At the same time, the procedure result is set to facilitate differentiation on CN side for identifying no-op start pipe and stop pipe. It is important to note that when starting a RUNNING pipe or stopping a STOPPED pipe, we need to consider the `isStoppedByRuntimeException` status of the pipe. Otherwise, certain procedures might be mistakenly skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As title. This PR is a follow-up to #11690, from now onwards, no-op start pipe and stop pipe will directly skip the entire procedure execution, avoiding the impact of rollback and other exceptional situations. At the same time, the procedure result is set to facilitate differentiation on CN side for identifying no-op start pipe and stop pipe.
It is important to note that when starting a RUNNING pipe or stopping a STOPPED pipe, we need to consider the
isStoppedByRuntimeExceptionstatus of the pipe. Otherwise, certain procedures might be mistakenly skipped.TODO:
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR