Fix LIMIT/OFFSET push down in GROUP BY MONTH#11714
Merged
JackieTien97 merged 10 commits intoapache:masterfrom Dec 18, 2023
Merged
Fix LIMIT/OFFSET push down in GROUP BY MONTH#11714JackieTien97 merged 10 commits intoapache:masterfrom
JackieTien97 merged 10 commits intoapache:masterfrom
Conversation
1. group by ([2016-7-30),1mo) results in 2017-7-31 due to 2017-2-28 2. group by ([2016-7-31),1mo) results in 2017-7-28 due to 2017-2-28
…it's only supported in Group by month without Align by device and in ascending order)
ycycse
changed the title
This reverts commit 5ff5520.
This reverts commit 5ff5520.
(startTime_n = startTime + n*step)
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/aggregation/timerangeiterator/AggrWindowIterator.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/DateTimeUtils.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/filter/operator/GroupByMonthFilter.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/utils/TimeDuration.java # iotdb-core/tsfile/src/test/java/org/apache/iotdb/tsfile/utils/TimeDurationTest.java
JackieTien97
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix the following problems: